Merged
Conversation
Some users complain about ringtone continuing to ring when a call is joined. It could not be reproduced but code wise it makes sense to call stopCallingSound here. This is adapted from the PR #6092 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Stops the calling/ringtone sound when a call is being prepared to prevent it from continuing after the user has joined a call.
Changes:
- Call
stopCallingSound()at the start ofprepareCall().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sowjanyakch
approved these changes
Apr 22, 2026
Contributor
Collaborator
Author
|
/backport to stable-23.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users complain about ringtone continuing to ring when a call is joined. It could not be reproduced but code wise it makes sense to call stopCallingSound here.
This is adapted from the PR
#6092
🏁 Checklist
/backport to stable-xx.x