build(scripts): only override styles on release if missing or outdated#1799
Merged
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
approved these changes
Jul 9, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Code-wise makes sense to me
| Arguments: | ||
| --version <nextcloud-version-major> - major version of Nextcloud to override styles for (e.g. "34"), default: the current built-in Talk's Nextcloud version | ||
| --help - show help | ||
| --port <number> - port to expose the Nextcloud server on, default: 6123 |
Contributor
There was a problem hiding this comment.
port is not needed anymore?
Contributor
Author
There was a problem hiding this comment.
No. In the past, the docker container with Nextcloud server had port exposed to fetch the styles on the host. To run 2 containers with different Nextcloud servers, we needed to set different ports.
Later, to avoid this issue entirely, we stopped exposing the port and switched to fetching styles via docker exec curl.
Contributor
Author
There was a problem hiding this comment.
The extract-nextcloud-styles script doesn't have port anymore, so --port in override-nextcloud-styles does nothing.
This was referenced Jul 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
build(server-styles): check if overrides are up-to-daterefactor(scripts): split override-nextcloud-styles into CLI and functionbuild(override-nextcloud-styles): only override if missing or outdated