Skip to content

refactor(chat): Upload voice messages and contacts with a single implementation - #2641

Merged
SystemKeeper merged 2 commits into
mainfrom
chore/noid/unify-chat-file-uploads
Aug 9, 2026
Merged

refactor(chat): Upload voice messages and contacts with a single implementation#2641
SystemKeeper merged 2 commits into
mainfrom
chore/noid/unify-chat-file-uploads

Conversation

@Ivansss

@Ivansss Ivansss commented Jul 31, 2026

Copy link
Copy Markdown
Member

Third step towards a single file upload implementation, on top of #2640.

Uploading a file into a conversation is the same three steps everywhere: resolve a destination, upload
it, announce it in the conversation. This adds one implementation of that and moves the voice message,
contact and resend paths onto it. The ShareConfirmationViewController changes will be done in a follow-up PR.

Behaviour changes:

  • A 404 or 409 no longer retries into the attachment folder when the upload started in the draft
    folder, which silently turned a subfolder upload into a read only share in the Talk folder
  • Shared contacts are posted with the contact name instead of a random UUID
  • Resending a private reply voice message now sends replyToToken

Needs manual testing with conversation_subfolders enabled and disabled: voice message, shared
contact, and a failing upload.

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Ivansss
Ivansss requested a review from SystemKeeper July 31, 2026 11:05
Base automatically changed from chore/noid/async-file-upload-api to main July 31, 2026 14:09
Ivansss added 2 commits August 9, 2026 15:11
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@SystemKeeper
SystemKeeper force-pushed the chore/noid/unify-chat-file-uploads branch from 2d44321 to 4c46122 Compare August 9, 2026 13:11
@SystemKeeper
SystemKeeper enabled auto-merge August 9, 2026 13:23
@SystemKeeper
SystemKeeper merged commit 5af2d5a into main Aug 9, 2026
10 checks passed
@SystemKeeper
SystemKeeper deleted the chore/noid/unify-chat-file-uploads branch August 9, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants