fix: register viewer by uniq name instead of "component"#5312
Merged
juliusknorr merged 1 commit intomainfrom Jan 25, 2024
Merged
fix: register viewer by uniq name instead of "component"#5312juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
- Anonymous function in object property has a name of the property - component - This name is used for global viewer component registration - `component` is not a valid name, because it is a built-in name for Vue and it registers a global component - Using named function to have an explicit name Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
juliusknorr
approved these changes
Jan 25, 2024
Contributor
Author
|
@skjnldsv Do you think this should be handled by Viewer? |
Member
|
Just stumbled upon this. 
https://github.com/nextcloud/viewer/blob/c3e5c751b0decef5dbc103474208b6142f9deef9/src/services/Viewer.js#L11-L21
https://github.com/nextcloud/viewer/blob/d531abe602996292c8c0c45d0c525afcdc58bea6/src/views/Viewer.vue#L853-L854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
componentis not a valid name, because it is a built-in name for Vue and it registers a global componentProbably should be handled by
Viewer, but I haven't found any other app with async component registration. I guess it is not possible to use 2 viewers with dynamic anonymous components.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)