chore(psalm): use getId() instead of id and add errors to baseline #8155
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/psalm-errors
branch
from
f509385 to
edfce92
Compare
Psalm expects the non-null id to be initialized in the constructor. But entity classes have properties which are typed but not set in constructor, because we’re only supposed to build them with static factory function fromRow or so. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/psalm-errors
branch
from
edfce92 to
bdc4847
Compare
max-nextcloud
changed the title
mejo-
approved these changes
Jan 15, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Code changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also works with the new snowflake ids.
Fixes psalm failures such as https://github.com/nextcloud/text/actions/runs/20987461914/job/60324608033?pr=8153