Skip to content

fix(menu): fix labels for new file actions#8295

Open
mejo- wants to merge 2 commits intomainfrom
fix/create_attachment_labels
Open

fix(menu): fix labels for new file actions#8295
mejo- wants to merge 2 commits intomainfrom
fix/create_attachment_labels

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Mar 2, 2026

Fixes: #8035

Together with nextcloud/collectives#2309 also brings this menu to the editor in Collectives.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

mejo- added 2 commits March 2, 2026 20:22
Fixes: #8035

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Mar 2, 2026
@mejo- mejo- added bug Something isn't working 3. to review regression labels Mar 2, 2026
mejo- added a commit to nextcloud/collectives that referenced this pull request Mar 2, 2026
Fixes: #2223

Requires nextcloud/text#8295

Signed-off-by: Jonas <jonas@freesources.org>
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Menu/ActionAttachmentUpload.vue 0.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with the collectives specific code in text - but since it's following the structure used by the files specific code and everything else would be a lot of work this seems like the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New file icons and labels for attachments are missing

2 participants