Conversation
mejo-
added
feature: formatting
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
benjaminfrueh
approved these changes
Mar 13, 2026
max-nextcloud
requested changes
Mar 13, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Now this also allows creating links within inline code blocks.
While having code in link titles seems fine, having links in inline code does not seem like a good idea. What would this even be serialized to?
So I suspect in order to make this work as intended we will need another check in setLink and related commands that confirms we're not inside an inline code block.
Not sure what to do about overlapping code and link.
Collaborator
Hum... so the serialization looks okay: |
max-nextcloud
approved these changes
Mar 13, 2026
Member
Author
|
/backport to stable33 |
The Tiptap inline code mark extension excludes all other mark types from coexisting with itself. This makes sense for most mark types, but link is an exception. Unfortunately there's no way to dynamically create a list of all marks when `excludes` is initialized, as this happens when compiling the editor schema, so the latter is not available yet. Thus to fix the bug while keeping the side effects small, we have to explicitely list all mark types except link and code in `excludes` in the code mark definition. Fixes: #4900 Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tiptap inline code mark extension excludes all other mark types from coexisting with itself. This makes sense for most mark types, but link is an exception.
Unfortunately there's no way to dynamically create a list of all marks when
excludesis initialized, as this happens when compiling the editor schema, so the latter is not available yet.Thus to fix the bug while keeping the side effects small, we have to explicitely list all mark types except link and code in
excludesin the code mark definition.Fixes: #4900
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)