fix(editorApi): fix callbacks on editor events#8517
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-
force-pushed
the
fix/editor_api_emit_events
branch
from
7a5e8b6 to
ac8240f
Compare
silverkszlo
reviewed
Apr 27, 2026
The new Editor.js wrapper component that got introduced in the indexedb PR broke event propagation from Editor.vue component to editorApi consumers. Fixes loading editor and updating read-only content in Collectives. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/editor_api_emit_events
branch
from
ac8240f to
62ce44d
Compare
silverkszlo
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Editor.js wrapper component that got introduced in the indexedb PR broke event propagation from Editor.vue component to editorApi consumers.
Fixes loading editor and updating read-only content in Collectives.
The
resolvedemit was a leftover (dead code) so I removed it.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)