Fix choice in while loops

[enoch85]

https://github.com/nextcloud/vm/blob/master/nextcloud_install_production.sh#L165-L166

Fix in all places!

[enoch85]

apps/previewgenerator.sh: done 11< results
apps/previewgenerator.sh: done 8< results
nextcloud_install_production.sh:choice=$(< results)
nextcloud_install_production.sh:choice=$(< results)
nextcloud_install_production.sh:done 11< results
nextcloud-startup-script.sh:done 9< results
additional_apps.sh:done 11< results

[enoch85]

Done in #1059

[enoch85]

Just for reference:

whiptails with --checklist must be:

while read -r -u [number-of-choices] choice <-------
do <-------
    case "$choice" in <-------
        ..................
        ;;
        *)
        ;;
    esac
done [number-of-choices]< results <-------
rm -f results

whiptails with --radiolist must be:

choice=$(< results)  <-------
    case "$choice" in  <-------
        ..................
        ;;
        *)
        ;;
    esac
rm -f results

[enoch85]

FYI @szaimen

[szaimen]

But I guess you could also solve at least the radiolist like in the cookielifetime script
(With if and elif)

[enoch85]

Actually, I think this was strange: https://github.com/nextcloud/vm/blob/master/apps/smbmount.sh#L266-L295 and I was about to change it to this https://github.com/nextcloud/vm/blob/master/nextcloud_install_production.sh#L160-L179

But I thought maybe you had a plan. Everything is solved now anyway, testing as we speak.

[szaimen]

Actually, I think this was strange: https://github.com/nextcloud/vm/blob/master/apps/smbmount.sh#L266-L295 and I was about to change it to this https://github.com/nextcloud/vm/blob/master/nextcloud_install_production.sh#L160-L179

But I thought maybe you had a plan. Everything is solved now anyway, testing as we speak.

Both methods should work 👍

[enoch85]

Both methods should work +1

I think we should use the same code everywhere. Please change to the standard used in all other places. It's cleaner IMO.

Thanks!

[enoch85]

whiptails are still broken........

Too tired now, have to sleep.

If you have time, please test all of them and try to fix it.

Thanks!

[enoch85]

OK, think I found it. The number must be equal to the number of choices.

We must revert to the old method: cc0e28b#diff-2912af18ccc7a96fbdf15892788006f2

[szaimen]

Wouldn't something like this work for radiolist and checklist?
That would be the cleanest way to do it imo.
Sry, have no time to test this at the moment.

choice=$(whiptail --radiolist  "text" "$WT_HEIGHT" "$WT_WIDTH" 4 \
"option 1" "description 1" ON \
"option 2" "description 2" OFF \
"option 3" "description 3" OFF 3>&1 1>&2 2>&3)

case "$choice" in
    "option 1")
        run command 1
    ;;
    "option 2")
        run command 2
    ;;
    "option 3")
        run command 3
    ;;
    *)
    ;;
esac

choice=$(whiptail --checklist  "text" "$WT_HEIGHT" "$WT_WIDTH" 4 \
"option 1" "description 1" ON \
"option 2" "description 2" OFF \
"option 3" "description 3" OFF 3>&1 1>&2 2>&3)

for element in "$choice"
do
    case "$element" in
        "option 1")
            run command 1
        ;;
        "option 2")
            run command 2
        ;;
        "option 3")
            run command 3
        ;;
        *)
        ;;
    esac
done

Because the inputbox is already afaik:
input=$(whiptail --inputbox "text" "$WT_HEIGHT" "$WT_WIDTH" 3>&1 1>&2 2>&3)

and the msg box is:
whiptail --msgbox "text" "$WT_HEIGHT" "$WT_WIDTH"

so everything would then be in a consecutive order:
msg_box -> inputbox -> radiolist -> checklist

[szaimen]

And do we need the backslashes in the whiptail list?