Skip to content

test(e2e): target exact Votings button#1273

Merged
hweihwang merged 1 commit into
mainfrom
fix/playwright-voting-selector
Jul 14, 2026
Merged

test(e2e): target exact Votings button#1273
hweihwang merged 1 commit into
mainfrom
fix/playwright-voting-selector

Conversation

@hweihwang

@hweihwang hweihwang commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What changed

Match the existing Votings button by its exact accessible name.

Why

Nextcloud server PR #61658 changed Files-row accessible names. A board named Voting ... now also matches the loose /voting/i selector, so Playwright strict mode finds both the board button and the Votings action.

Using menuitem is not valid on current main; that role appears only with the unrelated Excalidraw update in #1161.

Verification

  • Production build passes on Node 24.
  • The targeted voting E2E on Nextcloud master resolves and clicks the exact Votings action.
  • The remaining test flow is unchanged.

Refs nextcloud/server#61658.

Nextcloud master now includes board names in Files-row accessible
labels, so the loose /voting/i selector matches two buttons.

Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the fix/playwright-voting-selector branch from 9337bd5 to 4330b03 Compare July 14, 2026 15:46
@hweihwang hweihwang changed the title test(e2e): target voting menu item test(e2e): target exact Votings button Jul 14, 2026
@hweihwang
hweihwang merged commit 5d87af5 into main Jul 14, 2026
38 of 39 checks passed
@hweihwang
hweihwang deleted the fix/playwright-voting-selector branch July 14, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant