Add multi-arch support to arch process directive#6897
Merged
pditommaso merged 10 commits intomasterfrom Mar 17, 2026
Merged
Conversation
Allow comma-separated platform values in the `arch` directive (e.g. `arch 'linux/amd64,linux/arm64'`) to enable Wave to build multi-platform container images. - Refactor Architecture class with inner Arch value type holding normalized arch values - Add `platforms()` returning list of docker arch strings and `containerPlatform()` returning comma-joined string - Keep `dockerArch`/`spackArch` getters for backward compatibility (delegate to first arch) - Remove unused `platform`, `arch`, `target` fields - Update Wave to add fusion layers for each platform - Update AWS Batch handler to use `dockerArch` instead of removed `arch` field Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
bentsherman
reviewed
Mar 6, 2026
modules/nextflow/src/main/groovy/nextflow/processor/Architecture.groovy
Outdated
Show resolved
Hide resolved
jordeu
approved these changes
Mar 9, 2026
…re.groovy [ci skip] Co-authored-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Add `seqera.executor.provider` setting to specify the compute backend provider type (e.g. aws, local), used together with region to select the matching compute environment. Bump nf-seqera to 0.15.0 and sched-client to 0.41.0-SNAPSHOT. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Refactor Architecture class to support comma-separated architectures (e.g. `arch 'linux/amd64,linux/arm64'`). Multi-arch is fully supported by selected executors (Seqera) via platforms()/containerPlatform(). Other executors use getDockerArch()/getSpackArch() which return only the first (primary) architecture. Also rename inner class Arch to ArchEntry for clarity. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
bentsherman
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architectureclass to support comma-separated platform values in thearchdirective (e.g.arch 'linux/amd64,linux/arm64')Archvalue type holding normalized arch values, withplatforms()andcontainerPlatform()methodsdockerArch/spackArchgetters for backward compatibility (delegate to first arch)platform,arch,targetfields fromArchitecturedockerArchinstead of removedarchfieldTest plan
ArchitectureTest— single arch, multi-arch, map-based, normalize, toStringarch 'linux/amd64,linux/arm64'🤖 Generated with Claude Code