Skip to content

Fix bug with linting results comments.#745

Merged
ewels merged 1 commit intonextflow-io:masterfrom
ewels:master
Dec 4, 2025
Merged

Fix bug with linting results comments.#745
ewels merged 1 commit intonextflow-io:masterfrom
ewels:master

Conversation

@ewels
Copy link
Member

@ewels ewels commented Dec 4, 2025

Action should update existing comments instead of posting new ones, but there was an error from it looking for some outdated text which was changed. Merging this should stop it from posting new comments each time a new commit is pushed to a PR.

Action should update existing comments instead of posting new ones, but there was an error from it looking for some outdated text which was changed. Merging this should stop it from posting new comments each time a new commit is pushed to a PR.
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit c773290
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-training/deploys/69314af68ffc800008508f22
😎 Deploy Preview https://deploy-preview-745--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ewels
Copy link
Member Author

ewels commented Dec 4, 2025

Self-merging as is very straightforward and doesn't affect anything else.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Nextflow linting complete!

❌ 5 files had 33 errors
✅ 143 files had no errors

💡 Tip: Click filename locations to go directly to that code.

View all 33 issues
Type Location Message
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:11:1 Invalid include source: '/home/runner/work/training/training/hello-nextflow/solutions/5-hello-containers/modules/sayHello.nf'
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:12:1 Invalid include source: '/home/runner/work/training/training/hello-nextflow/solutions/5-hello-containers/modules/convertToUpper.nf'
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:13:1 Invalid include source: '/home/runner/work/training/training/hello-nextflow/solutions/5-hello-containers/modules/collectGreetings.nf'
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:24:5 sayHello is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:27:5 convertToUpper is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:27:20 sayHello is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:30:5 collectGreetings is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:30:22 convertToUpper is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:33:5 collectGreetings is not defined
Error hello-nextflow/solutions/5-hello-containers/hello-containers-2.nf:36:11 collectGreetings is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:11:1 Invalid include source: '/home/runner/work/training/training/hello-nf-core/solutions/composable-hello/modules/sayHello.nf'
Error hello-nf-core/solutions/composable-hello/hello.nf:12:1 Invalid include source: '/home/runner/work/training/training/hello-nf-core/solutions/composable-hello/modules/convertToUpper.nf'
Error hello-nf-core/solutions/composable-hello/hello.nf:13:1 Invalid include source: '/home/runner/work/training/training/hello-nf-core/solutions/composable-hello/modules/collectGreetings.nf'
Error hello-nf-core/solutions/composable-hello/hello.nf:14:1 Invalid include source: '/home/runner/work/training/training/hello-nf-core/solutions/composable-hello/modules/cowpy.nf'
Error hello-nf-core/solutions/composable-hello/hello.nf:24:5 sayHello is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:27:5 convertToUpper is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:27:20 sayHello is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:30:5 collectGreetings is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:30:22 convertToUpper is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:33:5 cowpy is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:33:11 collectGreetings is not defined
Error hello-nf-core/solutions/composable-hello/hello.nf:36:20 cowpy is not defined
Error hello-nf-core/solutions/core-hello-part2/nextflow.config:154:17 Invalid include source: '/home/runner/work/training/training/hello-nf-core/solutions/core-hello-part2/conf/test_full.config'
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:1:1 Invalid include source: '/home/runner/work/training/training/side-quests/solutions/workflows_of_workflows/modules/validate_name.nf'
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:2:1 Invalid include source: '/home/runner/work/training/training/side-quests/solutions/workflows_of_workflows/modules/say_hello.nf'
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:3:1 Invalid include source: '/home/runner/work/training/training/side-quests/solutions/workflows_of_workflows/modules/timestamp_greeting.nf'
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:11:24 VALIDATE_NAME is not defined
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:12:24 SAY_HELLO is not defined
Error side-quests/solutions/workflows_of_workflows/workflows/greeting.nf:13:26 TIMESTAMP_GREETING is not defined
Error side-quests/solutions/workflows_of_workflows/workflows/transform.nf:1:1 Invalid include source: '/home/runner/work/training/training/side-quests/solutions/workflows_of_workflows/modules/say_hello_upper.nf'
Error side-quests/solutions/workflows_of_workflows/workflows/transform.nf:2:1 Invalid include source: '/home/runner/work/training/training/side-quests/solutions/workflows_of_workflows/modules/reverse_text.nf'
Error side-quests/solutions/workflows_of_workflows/workflows/transform.nf:10:20 SAY_HELLO_UPPER is not defined
Error side-quests/solutions/workflows_of_workflows/workflows/transform.nf:11:23 REVERSE_TEXT is not defined

@ewels ewels merged commit fea0188 into nextflow-io:master Dec 4, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant