Skip to content

Remove module shebangs#841

Merged
ewels merged 2 commits intonextflow-io:masterfrom
ewels:no-shebangs
Feb 6, 2026
Merged

Remove module shebangs#841
ewels merged 2 commits intonextflow-io:masterfrom
ewels:no-shebangs

Conversation

@ewels
Copy link
Member

@ewels ewels commented Feb 5, 2026

Script shebangs are not needed in modules, they're never directly executed. We only need them in Nextflow scripts that have an entry workflow (and to be honest, they're not really needed there either).

Removed from all modules and removed from the "Hello Nextflow" training material where modules are created.

Fixes #837

@ewels ewels requested a review from vdauwera February 5, 2026 07:26
@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit fb8acee
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-training/deploys/69853e0e0fb5df0008852260
😎 Deploy Preview https://deploy-preview-841--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment was marked as off-topic.

Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like shebangs as a cosmetic 'this is nextflow' sort of thing, but not enough to fight you on it.

@ewels
Copy link
Member Author

ewels commented Feb 5, 2026

I like shebangs as a cosmetic 'this is nextflow' sort of thing, but not enough to fight you on it.

That's actually how I explained their need when I recorded this last night - cosmetic, helping IDEs know which language syntax highlighting to use etc. But I didn't really buy the explanation myself 😅 Also, we don't use them in nf-core modules.

Mostly I found it was a bit of friction to repeatedly have to copy two things into a file instead of one, when the second part didn't make any practical difference.

@ewels ewels merged commit cc3a0e5 into nextflow-io:master Feb 6, 2026
7 checks passed
@ewels ewels deleted the no-shebangs branch February 6, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Hello Nextflow' Suggestion: Remove shebangs

3 participants