Merged
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as off-topic.
This comment was marked as off-topic.
pinin4fjords
approved these changes
Feb 5, 2026
Collaborator
pinin4fjords
left a comment
There was a problem hiding this comment.
I like shebangs as a cosmetic 'this is nextflow' sort of thing, but not enough to fight you on it.
maxulysse
reviewed
Feb 5, 2026
maxulysse
approved these changes
Feb 5, 2026
Member
Author
That's actually how I explained their need when I recorded this last night - cosmetic, helping IDEs know which language syntax highlighting to use etc. But I didn't really buy the explanation myself 😅 Also, we don't use them in nf-core modules. Mostly I found it was a bit of friction to repeatedly have to copy two things into a file instead of one, when the second part didn't make any practical difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script shebangs are not needed in modules, they're never directly executed. We only need them in Nextflow scripts that have an entry workflow (and to be honest, they're not really needed there either).
Removed from all modules and removed from the "Hello Nextflow" training material where modules are created.
Fixes #837