Fix orphaned file deletion not being included in translation PRs#862
Merged
ewels merged 2 commits intonextflow-io:masterfrom Feb 9, 2026
Merged
Fix orphaned file deletion not being included in translation PRs#862ewels merged 2 commits intonextflow-io:masterfrom
ewels merged 2 commits intonextflow-io:masterfrom
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ❌ 1 files had 1 errors 💡 Tip: Click filename locations to go directly to that code. View all 1 issues
View formatting changes
|
The translate job deletes orphaned files but artifacts only contain new/updated translations. The merge job now runs ci-delete-orphans to delete orphans and stage them via git rm before creating the PR.
a576d02 to
abf3225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-delete-orphanscommand to delete orphaned translation files and stage deletions viagit rmProblem
The translate workflow detects and deletes orphaned files in the
translatejob, but:mergejob downloads artifacts and commits them, but deletions are lostSolution
Run orphan detection and deletion in the merge job (after translations are merged) using
git rmto both delete files and stage the deletions for commit.Fixes issue observed in #861