Bump minizip submodule#20
Merged
nextgeniuspro merged 4 commits intoFeb 4, 2025
Merged
Conversation
* Add CloseFile override for ZipFileSystem add gitignore for out (default for CPM/FetchContent/Visual Studio in-source builds) * Optional build of examples added library alias target for conformity Modified examples for in-lib build * using binary mode for opening NativeFile * Update miniz-cpp submodule url * Update readme --------- Co-authored-by: Yev <evg1985@gmail.com>
* Add CloseFile override for ZipFileSystem add gitignore for out (default for CPM/FetchContent/Visual Studio in-source builds) * Optional build of examples added library alias target for conformity Modified examples for in-lib build * using binary mode for opening NativeFile * Update miniz-cpp submodule url * Update readme --------- Co-authored-by: Yev <evg1985@gmail.com>
psyinf
marked this pull request as ready for review
January 27, 2025 21:58
Owner
I don't think it needed for this lib. I don't plan to make big changes in near future, only bug fixes and small improvements Thank you very much |
Contributor
Author
While not being needed it is handy for users of package managers such as CPM, conan or even plain CMake fetch_content, as it is "nicer" to address a library version by a tag rather than by a hash. E.g. |
Owner
|
Huh, ok, never though in this way. Probably you're right |
Owner
|
Added one release |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving towards fixed minizip
Also: would you mind creating a new release/tag