merge: Fixes for SQLite version 3.52.0#1969
Merged
Merged
Conversation
victorlin
force-pushed
the
victorlin/sqlite-errors
branch
2 times, most recently
from
b920811 to
e6c06c3
Compare
victorlin
changed the title
victorlin
force-pushed
the
victorlin/sqlite-errors
branch
from
e6c06c3 to
32d0532
Compare
SQLite version 3.52.0 introduced a bug¹ with .once that causes it to send results to stdout instead of through the pipe. .output is not affected by the bug, so we use it as a replacement. The last .output is effectively a no-op, but it's been added to replicate the behavior with .once.² ¹ https://sqlite.org/forum/forumpost/ea9c546fdf ² https://sqlite.org/cli.html#writing_results_to_a_file
victorlin
force-pushed
the
victorlin/sqlite-errors
branch
from
32d0532 to
afb7c26
Compare
Instead of always showing raw stderr from the SQLite subprocess, we now only show it on actual errors, and with a prefix to indicate its origin.
victorlin
force-pushed
the
victorlin/sqlite-errors
branch
2 times, most recently
from
f09a285 to
be83972
Compare
This matches the error message shown with duplicate ids in sequence files, and avoids needing to match the SQLite error message syntax in Cram tests.
victorlin
force-pushed
the
victorlin/sqlite-errors
branch
from
be83972 to
ce65076
Compare
Member
Author
|
Merging to fix failing tests. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1969 +/- ##
=======================================
Coverage 74.46% 74.47%
=======================================
Files 82 82
Lines 9110 9120 +10
Branches 1856 1858 +2
=======================================
+ Hits 6784 6792 +8
Misses 2021 2021
- Partials 305 307 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
A couple small improvements in error handling.
Related issue(s)
Addresses CI failures due to changes from new SQLite version, first noticed in scheduled run
Checklist