Conversation
… of .vcpu and .memory Job submissions with resourceRequirements correctly override the defaults from job definitions that use the newer resourceRequirements and those that use the older, deprecated vcpu and memory fields. Job submissions using the older fields only override job definitions that also use the older fields; otherwise they're ignored with only an easy to miss warning in the AWS console to alert you. Notably, using the AWS console to modify an existing job definition which uses vcpus and memory will switch the definition to resourceRequirements automatically in the new revision. This meant revising your old job definition in the AWS console could break --cpus and --memory for your `nextstrain build` invocations. It also means that --cpus and --memory would never have worked if your AWS job definitions were originally created with resourceRequirements. Resolves <#144>.
victorlin
approved these changes
May 27, 2022
Member
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
Didn't test personally, but your testing looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job submissions with resourceRequirements correctly override the
defaults from job definitions that use the newer resourceRequirements
and those that use the older, deprecated vcpu and memory fields. Job
submissions using the older fields only override job definitions that
also use the older fields; otherwise they're ignored with only an easy
to miss warning in the AWS console to alert you.
Notably, using the AWS console to modify an existing job definition
which uses vcpus and memory will switch the definition to
resourceRequirements automatically in the new revision. This meant
revising your old job definition in the AWS console could break --cpus
and --memory for your
nextstrain buildinvocations. It also meansthat --cpus and --memory would never have worked if your AWS job
definitions were originally created with resourceRequirements.
Resolves #144.
Testing
See #144 for how/what I tested.