Conversation
A pre-action yield matches the messaging of the `remote delete` command as of "remote delete: Update messaging to match pre-deletion behaviour" (bb4ab4c) and the behaviour of the S3 remote as of "remote.s3: Rework delete() to have a similar API to the other commands" (cc86a1a). The post-action yield was an oversight and bug in the initial remote implementation.
tsibley
force-pushed
the
trs/remote/nextstrain.org-delete-order
branch
from
2aff0a0 to
244b530
Compare
Contributor
Author
|
Whoops, I forgot #210 was based on this one and merged it first, thus merging this. I'm ok with that, given the scope of this change. My thinking for splitting them is that this obvious fix could get merged quickly and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre-action yield matches the messaging of the
remote deletecommandas of "remote delete: Update messaging to match pre-deletion behaviour"
(bb4ab4c) and the behaviour of the S3 remote as of "remote.s3: Rework
delete() to have a similar API to the other commands" (cc86a1a).
The post-action yield was an oversight and bug in the initial remote
implementation.
Testing