remote.nextstrain_dot_org: Handle 400 Bad Request errors#238
Merged
Conversation
Contributor
Author
|
Ugh, CI is failing (again) for unrelated reasons (again). This time, it appears to be a recent release of flake8 with more stringent config parsing. Will fix on another PR (again). |
This helps in particular with user-caused bad requests, such as trying to upload to dataset URLs which include underscores instead of slashes. It will also let us use 400 responses more widely on the server side since we know the CLI user will now see the error message. Related-to: <nextstrain/nextstrain.org#611>
2cbefb1 to
08fa0c3
Compare
Contributor
Author
|
Rebased to fix CI issues. |
corneliusroemer
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps in particular with user-caused bad requests, such as trying to upload to dataset URLs which include underscores instead of slashes. It will also let us use 400 responses more widely on the server side since we know the CLI user will now see the error message.
Related-to: nextstrain/nextstrain.org#611
Testing
Example of the error message: