Avoid fsspec/s3fs 2023.9.1 due to errors caused by auto_mkdir#313
Merged
joverlee521 merged 2 commits intomasterfrom Sep 18, 2023
Merged
Avoid fsspec/s3fs 2023.9.1 due to errors caused by auto_mkdir#313joverlee521 merged 2 commits intomasterfrom
auto_mkdir#313joverlee521 merged 2 commits intomasterfrom
Conversation
Changes to the `auto_mkdir` parameter in fsspec/filesystem_spec#1358 leads to the error described in fsspec/s3fs#790. Upstream fixes to come soon via fsspec/filesystem_spec#1365 but good to avoid versions that we know are broken.
Contributor
Author
|
Release with this change will fix our currently blocked automated AWS Batch builds that use the |
tsibley
approved these changes
Sep 18, 2023
Contributor
tsibley
left a comment
tsibley
left a comment
There was a problem hiding this comment.
Looks good by inspection. Both the built wheel and standalone archive from the CI run get the expected fsspec/s3fs version for me locally and successfully submit AWS Batch jobs instead of being broken.
Contributor
|
Ah, a brief changelog entry noting avoidance of a compatibility issue would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Changes to the
auto_mkdirparameter in fsspec/filesystem_spec#1358 leads to the error described in fsspec/s3fs#790.Upstream fixes to come soon via fsspec/filesystem_spec#1365 but good to avoid versions that we know are broken.
Checklist