Fix pyright errors for requests#530
Merged
Merged
Conversation
requests v2.34.0 includes inline type annotations that cause pyright errors. This commit attempts to fix and/or ignore those errors as appropriate. Resolves #529
victorlin
reviewed
May 12, 2026
Based on suggestions from @victorlin in review of #530 1. Assert value instead of type to be consistent with other assertions in the repo. 2. Use type narrowing instead of coercion 3. nextstrain_dot_org/download: Always write raw bytes `iter_content` can potentially return bytes if the `response.encoding` is None,¹ so just always write raw bytes. ¹ <https://github.com/psf/requests/blob/6404f345e562d962abe6700a1c357ec1e7e18232/src/requests/utils.py#L599-L600>
victorlin
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
requests v2.34.0 includes inline type annotations that cause pyright errors. This commit attempts to fix and/or ignore those errors as appropriate.
Related issue(s)
Resolves #529
Checklist