Adds required GPC references#21
Merged
Merged
Conversation
j23414
approved these changes
Aug 8, 2024
Contributor
j23414
left a comment
There was a problem hiding this comment.
Thanks! I see you're using the Josiah reference which matches RefSeq and seems good to me.
This does does make me wonder if we should swap our current L and S segment references to Josiah for consistency. Currently they are:
- lassa_l.gb (Pinneo-NIG-1969)
- lassa_s.gb (Nig08_04)
But that's a separate issue and PR. If I don't see other comments, I'll go ahead and merge this at the end of the week.
Contributor
|
I think we can ignore this check. I kicked it off to see what would happen on an external PR. |
Collaborator
Author
|
Great!
The Josiah is the widely recognized reference in the field. I agree it
should be used for the segments as well. This would ensure "universally
comparable results".
…On Thu, 8 Aug 2024, 17:23 Jennifer Chang, ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks! I see you're using the Josiah reference which matches RefSeq
<https://www.ncbi.nlm.nih.gov/labs/virus/vssi/#/virus?SeqType_s=Nucleotide&VirusLineage_ss=Mammarenavirus%20lassaense,%20taxid:3052310&SourceDB_s=RefSeq>
and seems good to me.
This does does make me wonder if we should swap our current L and S
segment references to Josiah for consistency. Currently they are:
- lassa_l.gb
<https://github.com/nextstrain/lassa/blob/da8019bfe93e22bc7d12b683076f6e7ea5302df3/phylogenetic/defaults/lassa_l.gb>
(Pinneo-NIG-1969)
- lassa_s.gb
<https://github.com/nextstrain/lassa/blob/da8019bfe93e22bc7d12b683076f6e7ea5302df3/phylogenetic/defaults/lassa_s.gb>
(Nig08_04)
But that's a separate issue and PR. If I don't see other comments, I'll go
ahead and merge this at the end of the week.
—
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOVPUJTOIOLU3RF64AXVM53ZQOEPPAVCNFSM6AAAAABME6DYSKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRYGIYTSMZZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
For creating GPC trees, this PR adds the required GPC reference files.
Related issue(s)
Checklist