Skip to content

Adds required GPC references#21

Merged
j23414 merged 1 commit into
nextstrain:mainfrom
JoiRichi:main
Aug 9, 2024
Merged

Adds required GPC references#21
j23414 merged 1 commit into
nextstrain:mainfrom
JoiRichi:main

Conversation

@JoiRichi
Copy link
Copy Markdown
Collaborator

@JoiRichi JoiRichi commented Aug 7, 2024

Description of proposed changes

For creating GPC trees, this PR adds the required GPC reference files.

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 changed the title added required GPC references Adds required GPC references Aug 7, 2024
@j23414 j23414 self-requested a review August 7, 2024 18:28
Copy link
Copy Markdown
Contributor

@j23414 j23414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see you're using the Josiah reference which matches RefSeq and seems good to me.

This does does make me wonder if we should swap our current L and S segment references to Josiah for consistency. Currently they are:

But that's a separate issue and PR. If I don't see other comments, I'll go ahead and merge this at the end of the week.

@j23414
Copy link
Copy Markdown
Contributor

j23414 commented Aug 8, 2024

I think we can ignore this check. I kicked it off to see what would happen on an external PR.

@JoiRichi
Copy link
Copy Markdown
Collaborator Author

JoiRichi commented Aug 8, 2024 via email

@j23414 j23414 merged commit 6cb60e5 into nextstrain:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants