Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise omicron recombinants #915

Open
jameshadfield opened this issue Apr 13, 2022 · 2 comments
Open

Visualise omicron recombinants #915

jameshadfield opened this issue Apr 13, 2022 · 2 comments

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Apr 13, 2022

This issue contains two examples of visualising recombinants.

For this issue I've chosen to display BA.1, BA.2, BA.4 and BA.5 as distinct recombinants, however that choice is clearly up for grabs. What workflow changes we make to generate them is also up for grabs, here I'm using a tree from Trevor's #913 and pruning out clades.

Option 1: Separate them into subtrees

URL: https://nextstrain.org/staging/omicron-recombinant/subtrees

image

Option 2: Add a "potential recombinant" colouring so you can explode them

URL: https://nextstrain.org/staging/omicron-recombinant/explodable?c=recombinant

image

cc @huddlej @rneher @trvrb @emmahodcroft

@huddlej huddlej self-assigned this Apr 14, 2022
@huddlej huddlej removed their assignment May 6, 2022
@huddlej
Copy link
Contributor

huddlej commented May 6, 2022

What do we think is the most biologically appropriate representation of these data in a data structure?

  • Encoding the potential recombinants as subtrees indicates strong evidence that the subtrees do not belong to a single tree. This encoding enforces a specific set of recombination events.
  • Encoding the recombinants as a metadata annotation that we can "explode" or color by indicates uncertainty about the nature of the recombination events. This encoding allows multiple different possible annotations of recombination events.

After working with @nicfel's recombination networks a little bit and seeing the complexity and uncertainty there, I prefer the less stringent encoding of events by metadata instead of by subtrees.

Related to this, should we plan to standardize on the same approach for reassortment that we use for recombination? For example, encoding MCCs for H3N2 from TreeKnit as metadata annotations also makes sense, given the variability of the MCC annotations with different runtime parameters.

@emmahodcroft
Copy link
Member

I agree with John and also think, that at least for the BAs, encoding as metadata that can be exploded or not is nice to reflect the uncertainty.

One question it raises is whether in cases where recombination is more certain (the X lineages), that would be better to have as a separate tree. How much it influences the phylogeny may be a line-drawing point - 'more recombinant' things may just simply not fall well at all into a conventional phylogeny.

If that happened, would we be able to and/or want to do both? In this example, have BAs as metadata to explode by choice, but have X lineages 'always exploded'? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Review
Development

No branches or pull requests

3 participants