Use unversioned S3 bucket and move S3 path to config#45
Merged
Conversation
* Makes the S3 path configurable in just one place rather than hardcoded in multiple scripts. * Renames s3_bucket to s3_dst_unversioned since it now contains the full destination path, not just a bucket name.
kimandrews
force-pushed
the
update-s3-bucket-params
branch
from
460cc03 to
882d565
Compare
joverlee521
reviewed
Jan 30, 2026
This makes the format consistent between s3_dst_unversioned and deploy_url
joverlee521
approved these changes
Jan 30, 2026
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Changes look good from inspection, just need to test.
joverlee521
reviewed
Feb 3, 2026
| - build-configs/nextstrain-automation/deploy.smk | ||
|
|
||
| s3_dst_unversioned: "s3://nextstrain-data-unversioned/files/workflows/tb/" | ||
| s3_dst_unversioned: "s3://nextstrain-data-unversioned/files/workflows/tb" |
Contributor
joverlee521
approved these changes
Feb 4, 2026
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Looks good to merge after latest trial run.
Contributor
|
Scheduled automated run worked as expected. Will need to follow up to clean up files on the versioned S3 bucket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
nextstrain-databucket tonextstrain-data-unversionedbucket since versioning is not needed for the tbprofiler and snippy outputss3_bucketconfig option tos3_dst_unversionedwith this reasoning:_dstbecause it now contains the full destination path, not just the bucket name_unversionedbecause we want to reserve thes3_dstparameter name for future changes that will upload build metadata and VCF tonextstrain-dataRelated issue(s)
Closes #41
Closes #43
Checklist