NAPI C++ test fail for HDF4 and XML

[eugenwintersberger]

It seems that after some changes to the attribute interface the tests for C++ fail with HDF4 and XML.
For HDF4 I get the following error message

wintersb@haso228w1:$ ./napi_test_cpp-hdf4 
NXinquirefile found: napi_test_cpp.hdf
This is a HDF4 file, attribute array API is not supported here 
terminate called after throwing an instance of 'NeXus::Exception'
  what():  NXgetnextattr failed
Aborted

and for XML

wintersb@haso228w1:$ ./napi_test_cpp-xml 
NXinquirefile found: napi_test_cpp.xml
This is an XML file, attribute array API is not supported here 
terminate called after throwing an instance of 'NeXus::Exception'
  what():  NXgetnextattr failed
Aborted

I guess this should be easy to fix for those people who made the changes to the attribute interface.
Please, when you make changes in the code, always ensure that all tests are green.

[zjttoefs]

This is not really fixable and hence the desired, expected behaviour.

Tobias

---

From: Eugen Wintersberger notifications@github.com
Sent: 19 May 2016 12:08 pm
To: nexusformat/code
Subject: [nexusformat/code] NAPI C++ test fail for HDF4 and XML (#426)

It seems that after some changes to the attribute interface the tests for C++ fail with HDF4 and XML.
For HDF4 I get the following error message

wintersb@haso228w1:$ ./napi_test_cpp-hdf4
NXinquirefile found: napi_test_cpp.hdf
This is a HDF4 file, attribute array API is not supported here
terminate called after throwing an instance of 'NeXus::Exception'
what(): NXgetnextattr failed
Aborted

and for XML

wintersb@haso228w1:$ ./napi_test_cpp-xml
NXinquirefile found: napi_test_cpp.xml
This is an XML file, attribute array API is not supported here
terminate called after throwing an instance of 'NeXus::Exception'
what(): NXgetnextattr failed
Aborted

I guess this should be easy to fix for those people who made the changes to the attribute interface.
Please, when you make changes in the code, always ensure that all tests are green.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/426

[eugenwintersberger]

Ok - in this case I will change the test accordingly.

[zjttoefs]

Sorry, my mistake.

[zjttoefs]

I thought the test was trying to read or write attribute arrays in backends where that isn't possible. Reading attributes in well formed file should still work using the legacy attribute API.

I don't understand why that is a problem in C++ but not in C. Maybe there lies the answer.

[zjttoefs]

It does indeed and someone didn't update the message for the exception.

But I should be able to fix that. Good we have the test. Thanks for raising that Eugen!

[zjttoefs]

@eugenwintersberger could you include the test in the "make test" procedure?

Ideally so it runs for all compiled backends, obviously.

[eugenwintersberger]

Actually they are all in the test target of make. I used the call of the individual test to show the error message which is not shown when using make test.

[zjttoefs]

You are absolutely correct! Once I enable stuff like hdf4 and c++ it "automatically" appears.
We would not be here if the computer could guess what we are trying to do, so I cannot complain.

Nice work, thanks!

[zjttoefs]

So the problem is that with just the experience of HDF5 people expect NXgetnextattra at al to work.
But for XML/HDF4 files that's not the case.

NXgetnextattra could be calling the "old" attribute API under the hood. But the NXgetattra is too different and NXputattra is near impossible to do.

Do we need to fall back to the original API? Can you tell what kind of file is open from the NAPI?