Adds git based versioning for get_nxdl_version#1318
Closed
domna wants to merge 4 commits intonexusformat:mainfrom
Closed
Adds git based versioning for get_nxdl_version#1318domna wants to merge 4 commits intonexusformat:mainfrom
get_nxdl_version#1318domna wants to merge 4 commits intonexusformat:mainfrom
Conversation
PeterC-DLS
reviewed
Feb 8, 2024
Contributor
Author
|
Currently it's failing because it needs reformatted according to black>24. This will be fixed by #1344 |
Contributor
|
You need to rebase to the tip of main for the fixed formatting of |
domna
force-pushed
the
vcs-based-versioning
branch
from
34a2ca9 to
e4e25a2
Compare
Contributor
|
And then format your altered file |
Contributor
Author
That's the grouping of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started to add a version based on the git tag and hash in pynxtools (see FAIRmat-NFDI/pynxtools#124) and I thought could be useful as a general feature. This PR is just to start a discussion whether it is desired to have a versioning like this in this repository, too.
When a git repository is available it constructs a version string based on the last tag, commit distance and commit hash. If no repository is available this falls back to reading
NXDL_VERSION.