nxstxm: doc elements can have dim elements but this was not the intention#1373
Merged
woutdenolf merged 1 commit intomainfrom Sep 27, 2024
Merged
nxstxm: doc elements can have dim elements but this was not the intention#1373woutdenolf merged 1 commit intomainfrom
woutdenolf merged 1 commit intomainfrom
Conversation
woutdenolf
changed the title
Contributor
|
Are you saying that this is just a typo/bug that this pull fixes? |
Contributor
Author
|
Yes, currently it is this: <doc>
<dim ... />
</doc>This is invalid syntax. When reading the doc, it seems clear that the idea was to actually document the NXDL |
benajamin
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.