Fairmat 2024: new common base classes #1426
Conversation
…d on feedback from @RubelMozumder, @lukaspie, as well as @sanbrock
Application definition for XPS
…or_circuits Cleaned the too many base classes for circuits and cleaned base classes for describing a computer
Make geometries and sourceTYPE recommended in NXxps
change docs in NXcollectioncolumn
…ses by definitions in appdefs
…NXms with NXmicrostructure to avoid confusing the symbol convention with mass spectrometry as the abbreviation NXms may suggest
…con and eventually make this NXmicrostructure
black formatting isort dev_tools
|
Any new classes, whether intended to be a base class or an application definition, must go into contributed definitions until they are ratified by the NIAC. |
prjemian
left a comment
prjemian
left a comment
There was a problem hiding this comment.
Any new classes must be add to contributed_definitions/, not directly to base_classes/ or application_definnitions/.
|
See changes made 2025/06/16 in the top-level description of the PR |
|
@mkuehbach I think eventually, when we have the four PRs that are mentioned right at the top here merged, we can just close this PR. I don't think that there is anything here that was not discussed in the other PRs. But we can double check afterwards. My suggestion: we leave this PR open until the others have been merged, do a rebase afterwards, and if there is nothing left to propose, only then we close here. Note that |
lukaspie
force-pushed
the
fairmat-2024-common-base-classes
branch
from
5595da9 to
8d08c37
Compare
|
@mkuehbach I went back and merged the main branch into this one. I suspect the remaining new classes are not needed anymore, right? Then I would close here. |
|
@lukaspie thank you, correct:
Yes, this PR can be closed as resolved by previously voted and merge FAIRmat-2024 PRs |
8 participants
These introduces new base classes that are needed for more than one of these other PRs:
#1422
#1423
#1424(merged already)#1425 (votes passed, acceptance but not merged yet as of 2025/06/16)
Bundling for easier review.
Update 2025/06/16, commit
3b597b8Most changes that are here proposed have been superseeded by other PRs, for some, decisions have already been taken, that make the changes here obsolete. This PR needs to be updated to implement the following, almost all changes here are obsolete, the PR should be revisited when #1422, #1423, and #1425 have been merged:
base classes
NXcomponentas a parent base class #1525, rebaseNXpid_controllerto base_classes #1528, revertcontributed_definitions