Skip to content

complex units, such as eV/mm#1489

Merged
prjemian merged 2 commits intomainfrom
1435-complex-units-like-eV-per-mm
Oct 15, 2024
Merged

complex units, such as eV/mm#1489
prjemian merged 2 commits intomainfrom
1435-complex-units-like-eV-per-mm

Conversation

@prjemian
Copy link
Copy Markdown
Contributor

@prjemian prjemian commented Sep 30, 2024

@prjemian prjemian added this to the NXDL 2025 milestone Sep 30, 2024
@prjemian prjemian self-assigned this Sep 30, 2024
@prjemian
Copy link
Copy Markdown
Contributor Author

prjemian commented Oct 14, 2024

@sanbrock What else needs to be done to make this PR ready for review?

@sanbrock
Copy link
Copy Markdown
Contributor

sanbrock commented Oct 14, 2024

Documentation page where Unit Categories are described need to be updated, too.

@prjemian
Copy link
Copy Markdown
Contributor Author

prjemian commented Oct 14, 2024 •
edited
Loading

Ignore this, it involves items from a previous build.

Details

CI reports a build error but no specifics. Locally, I see this problem after running make prepare html:

...projects/NeXus/definitions/build/manual/source/classes/contributed_definitions/NXimage_set_em_bf.rst:document isn't included in any toctree

Not seeing that NXDL file:

(bluesky_2024_3) prjemian@arf:~/.../NeXus/definitions$ ls -1 contributed_definitions/NXimage*
contributed_definitions/NXimage_set_em_adf.nxdl.xml
contributed_definitions/NXimage_set_em_kikuchi.nxdl.xml
contributed_definitions/NXimage_set.nxdl.xml

@prjemian
Copy link
Copy Markdown
Contributor Author

prjemian commented Oct 14, 2024

How about this?

image

@prjemian prjemian marked this pull request as ready for review October 14, 2024 21:28
@prjemian prjemian requested a review from a team October 14, 2024 21:28
sanbrock
sanbrock approved these changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prjemian prjemian merged commit c122513 into main Oct 15, 2024
@prjemian prjemian deleted the 1435-complex-units-like-eV-per-mm branch October 15, 2024 07:08
@lukaspie lukaspie mentioned this pull request Jan 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees

@prjemian prjemian

Labels

NIAC approved

Projects

NIAC 2024 project
Status: Done

Milestone

NXDL 2025

Development

Successfully merging this pull request may close these issues.

complex units, like eV/mm

2 participants

@prjemian @sanbrock