Merged
Conversation
Contributor
prjemian
commented
Oct 15, 2024
- close validating XML files for area detector HDF5 writer #1380
Contributor
Author
PeterC-DLS
reviewed
Oct 15, 2024
PeterC-DLS
reviewed
Oct 16, 2024
Contributor
PeterC-DLS
left a comment
There was a problem hiding this comment.
LGTM
BTW layout.xml doesn't have schema metadata
Contributor
Author
|
Can you explain?
…On Wed, Oct 16, 2024, 3:25 AM Peter Chang ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM
BTW layout.xml doesn't have schema metadata
—
Reply to this email directly, view it on GitHub
<#1497 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMFWCEZ7PKVLMTEEL3DZ3YPHTAVCNFSM6AAAAABP7RXGLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZRGYYDCNBSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
cf So there's a reference to the schema in the latter file |
Contributor
Author
|
The metadata about XML Schema location is not necessary to validate the XML layout files. The schema location was not added in ADCore since it was mentioned as an addition for layout files. |
Contributor
|
Sure, I was just remarking on its absence as it's inconsistent. |
PeterC-DLS
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
