Application Definition and Base Classes for SPM Domain (STS, STM, and AFM)#1516
Closed
RubelMozumder wants to merge 1148 commits intonexusformat:mainfrom
Closed
Application Definition and Base Classes for SPM Domain (STS, STM, and AFM)#1516RubelMozumder wants to merge 1148 commits intonexusformat:mainfrom
RubelMozumder wants to merge 1148 commits intonexusformat:mainfrom
Conversation
* Add a reference to NXmpes to NXarpes * Make reference an actual rst link * Refer to `NXmpes_arpes` * modify reference to NXmpes_arpes --------- Co-authored-by: Lukas Pielsticker <50139597+lukaspie@users.noreply.github.com>
…asses Fused NXimage_r_set, NXimage_c_set, NXimage_r_set_diff into a single …
Promote component_em to generally usable base class NXcomponent
NXopt workshop updates, everything seems to work fine - as well with future updates of ellips/raman readers.
Sprint22 matwerk #248
…d on feedback from @RubelMozumder, @lukaspie, as well as @sanbrock
Application definition for XPS
…or_circuits Cleaned the too many base classes for circuits and cleaned base classes for describing a computer
Make geometries and sourceTYPE recommended in NXxps
change docs in NXcollectioncolumn
…ses by definitions in appdefs
…NXms with NXmicrostructure to avoid confusing the symbol convention with mass spectrometry as the abbreviation NXms may suggest
…con and eventually make this NXmicrostructure
pulse_delay in NXbeam
Add CSS tweak to hide summary
… contributed but implicitly as a dependency of NXem, NXem_ebsd, NXem_img proposed for voting and acceptance
* update NXxrd.yaml * update NXxrd.nxdl
NXsource: type extended, previous_source added
Suggestions from Lukas
NXstm, NXaf, NXspm and base classes NXlockin, NXbias_spectroscopy, cantilever_spm, NXbias_sweep, NXpiezo_config_spm, NXpositioner_spm, NXscan_control, NXpiezoelectric_material and NXrcs. Finish review comments from Lev.
This reverts commit 3aeb39e.
This reverts commit 317a367.
…r the NXsample for verbose purpose.
* space. * Modified some descriptions trying to clarify the meaning of the elements. Please check them! Modified:Update NXafm.yaml * NXbias_spectroscopy.yaml * Update NXscan.yaml I just added a slight clarification what we mean under the word scan. However, it makes me wonder whether this should be more a base class than an application definition. And whether the control parameter set should be only positional. So, I have some doubts here... * Update NXcantilever_spm.yaml added some explanation and clarification to the cantilever properties and what are the driving details of cantilever oscillations * Update NXcircuit.yaml minor changes to allow for multichannel boards, e.g. 4 or 16 channel A/D converters or amplifiers * Update NXlockin.yaml Minor changes in documentation, removed some redundant information on the demodulated signal. * Update NXpiezo_config_spm.yaml minimal changes in docstrings * Update NXpositioner_spm.yaml minor correction, the Z positioner has no idea where the sample is, so sample - probe distance is unknown at this point * Update NXscan_control.yaml some minor comment changes * Generated nxdl files. * Revert "Update NXscan.yaml" This reverts commit 3f376f0. This file is covered by #304 #304 --------- Co-authored-by: T. Haraszti <haraszti@dwi.rwth-aachen.de>
Contributor
Author
|
This PR needs to be recreated excluding the necessary changes which is not part of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.