Skip to content

update ci.yaml to use actions/upload-artifact@v4, black format#1536

Merged
lukaspie merged 2 commits intonexusformat:mainfrom
FAIRmat-NFDI:update-github-actions-artifact
Feb 3, 2025
Merged

update ci.yaml to use actions/upload-artifact@v4, black format#1536
lukaspie merged 2 commits intonexusformat:mainfrom
FAIRmat-NFDI:update-github-actions-artifact

Conversation

@lukaspie
Copy link
Copy Markdown
Contributor

@lukaspie lukaspie commented Jan 31, 2025

actions/upload-artifact@v3 is deprecated as of Jan 30. This updates to v4.

@PeterC-DLS would you be able to review this? All builds in the other branches are failing because of the deprecation.

This PR also contains a change to dev_tools/tests/test_nxdl_utils.py that comes from using a newer version of black (as black is not pinned in this repo).

@lukaspie lukaspie requested a review from PeterC-DLS January 31, 2025 09:46
@lukaspie lukaspie changed the title update ci.yaml to use actions/upload-artifact@v4 update ci.yaml to use actions/upload-artifact@v4, black formatting Jan 31, 2025
@lukaspie lukaspie changed the title update ci.yaml to use actions/upload-artifact@v4, black formatting update ci.yaml to use actions/upload-artifact@v4, black format Jan 31, 2025
@rayosborn
Copy link
Copy Markdown
Contributor

It might be worth looking into using dependabot to keep Github Actions updated automatically.

Copy link
Copy Markdown
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit f87e273 into nexusformat:main Feb 3, 2025
@lukaspie lukaspie deleted the update-github-actions-artifact branch February 3, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants