Closed
Conversation
…definition below instrument that was required with the previous design. The key idea always was to have one group where static props of the instrument are stored and another group (event_data) where dynamic values are stored, so far the implementation for this recreated all concepts of the instrument on the one hand in NXapm_msr and on the other hand in NXevent_data_apm. However, now with base class inheritance supported and accepted by the NIAC, it would be much better to refactor NXapm_msr towards a base class called NXinstrument_apm that offers a dictionary for the concepts for static and typically quantities with more dynamic i.e. frequently changing values. Thereby measurement and NXevent_data_apm can just inherit NXinstrument_apm and thus the description of the NXevent_data_apm base class becomes much slimmer, less prone to making manual errors like copy-paste, the appdef will then just constrain for which concepts inherited from either NXinstrument_apm will be required, then possibly one may even remove NXevent_data_apm altogether via eventID(NXobject) with a child NXinstrument_apm
…msr refactored into NXinstrument_apm, next and last step, check that relevant groups of NXinstrument_apm are defined and constrained properly in the NXapm appdef to complete the BREAKING REFACTORING
…iles from CompositionSpace (NFDI-MatWerk) or paraprobe-toolbox (FAIRmat) into NOMAD for the apmapp developments
…ts and generate NXDL files
…specific post-processing routines
… its name to context to make clearer what is meant and why this could be useful
…gainst the schema using dataconverter aka validation
Fixes in NXmpes
First round of bugfixes to prepare an update and release for EM and APM examples in NOMAD and pynxtools{-em, -apm} parsers
Remaining bugfixes on definitions to prepare pynxtools v0.10.1 release
* Remove duplication of the concept in base class and app def, delete bias_sweep which come through NXbias_spectrocopy base class, fix some exists attributes. * Check sts. * fix afm. * remove NXbias_sweep. * fix tests. * tiny fix. * oscillator excitation. --------- Co-authored-by: Rubel <rubel.mozumder@outlook.com>
use correct enum in `NXelectronalyzer` axes attribute
…e deleted as they can always be recovered if really needed but currently pollute the repo unnecessarily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SORRY THIS WAS A MISTAKE