[Bug fix] Units in NXxps/NXbeam/beam_direction#1567
Merged
lukaspie merged 1 commit intonexusformat:mainfrom Jul 1, 2025
Merged
[Bug fix] Units in NXxps/NXbeam/beam_direction#1567lukaspie merged 1 commit intonexusformat:mainfrom
NXxps/NXbeam/beam_direction#1567lukaspie merged 1 commit intonexusformat:mainfrom
Conversation
Contributor
Author
|
@PeterC-DLS did you get a chance to look at this already? |
Contributor
Author
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the units in
NXxps/NXbeam/beam_directionsuch that they match with the recently changed unitsNXbeam/BEAMdirection.@PeterC-DLS I hadn't realized you had changed the units in
NXbeamas well. This should be an easy bug fix not requiring a vote.