Merged
Conversation
format style consistently too
Contributor
Author
|
@PeterC-DLS : Is this ready to merge? |
Contributor
|
I guess so. It may be missing a discussion on how NeXus versus CIF. |
Contributor
Author
|
@zjttoefs , @mkoennecke : you have been requested to review this PR. |
zjttoefs
approved these changes
Jun 15, 2017
Contributor
zjttoefs
left a comment
zjttoefs
left a comment
There was a problem hiding this comment.
I pushed two commits with the only comments I had.
In the examples all vectors are integers and that's consistent with the nxdl, so changed for NX_NUMBER as data type.
In the euler example I remove commas and added the (recommended) explicit end to the chain. I did not wrap the motion axis into NXtranformations. That might be nice, but would need some words as well.
mkoennecke
approved these changes
Jun 21, 2017
Contributor
mkoennecke
left a comment
mkoennecke
left a comment
There was a problem hiding this comment.
This appears OK with me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is this ready to merge?