Closed
Conversation
Added nComp arrays to four fields which need them. This is only needed if it is intended to continue using the nComp arrays. Signed-off-by: Michael Wharmby <michael.wharmby@diamond.ac.uk>
Contributor
|
The idea at the time was to prefer NXsample_component and maintain legacy support for nComp. It was a conscious decision not to add nComp to new fields. |
Contributor
Author
|
Fine. That makes sense, I just noticed the discrepancy and thought it worth pointing out. Thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added nComp arrays to four fields which need them. This is only necessary
if it is intended to continue using the nComp arrays, rather than using
NXsample_component. Nxsample_component looks like the better solution,
however.
Signed-off-by: Michael Wharmby michael.wharmby@diamond.ac.uk