Conversation
Class to describe concerted motion of a set of NXpositioners, for example a diffractometer or a collection of piezoelectric positioners in a mirror Signed-off-by: Michael Wharmby <michael.wharmby@diamond.ac.uk>
prjemian
left a comment
prjemian
left a comment
There was a problem hiding this comment.
- change file name to
NXstage.nxdl.xml
with this change, passes punx validation tests:
prjemian@ookhd .../definitions/contributed_definitions $ punx st NXstage.nxdl.xml
NXstage
description
name
orientation : NXtransforms
positioner1 : NXpositioner
positioner2 : NXpositioner
prjemian@ookhd .../definitions/contributed_definitions $ punx va NXstage.nxdl.xml
('NXstage.nxdl.xml', ' validates')
|
Regarding how to use names which are not defined by the NXDL spec, there is an issue (#562) to standardise amongst the NXDL files. I recommend that you comment on that issue, then modify the NXDL file (and update this PR) accordingly. This will enable automated processing of NXDL files (such as for data file validation) to recognize when a name is allowed to vary. |
|
@mtwharmby : |
|
Thanks very much. I'll review the changes and push them in. I've been talking to @markbasham about this offline and also following from the telco I think the structure of this is going to change slightly, but will certainly include your changes. Thanks again! |
yayahjb
left a comment
yayahjb
left a comment
There was a problem hiding this comment.
What is the type NXtransforms? What is the relationship to NXtransformations?
|
It's a typo. Because I was rushing. Sorry! |
mkoennecke
left a comment
mkoennecke
left a comment
There was a problem hiding this comment.
NXstage is basically a NXtransformations group with NXpositioners rather then values. There is a huge overlap here and I do not see why this is needed. Would it be sufficient to add name and description fields to NXtransformations to cover this use case?
|
Don't have time to fix this for today's telco and I think I've not expressed what I wanted to do very well with this. Will discuss more offline with @markbasham and others and put in a fresh pull request. |
4 participants
Class to describe concerted motion of a set of NXpositioners, for example a diffractometer
or a collection of piezoelectric positioners in a mirror.
Signed-off-by: Michael Wharmby michael.wharmby@diamond.ac.uk