Update nf-test snapshot#52
Conversation
|
@mashehu I've updated the test snapshot, but nf-test still fails, do you have an idea why and also how to proceed? Thanks! |
|
looks like the test produces more files in the CI then you currently have. How did you update your snapshots? |
nf-test test tests/default.nf.test --profile docker --update-snapshot |
|
Can you try it with |
|
@mashehu, it seems to not fully resolve it... |
|
I excluded a bit more unstable R files from the snapshot (should just check names for them). Can you try to recreate the snapshot on your side again @BenjaminWehnert1008 ? |
|
@mashehu @MaximilianStammnitz after further expanding the ignore file, the test is now running without any failures. Is it ready to be merged? And what is the next step? Thanks! :) |
amazing @BenjaminWehnert1008, I hope this looks good enough for the merge !! |
| **/fitness_estimation_mutscan_edgeR.tsv | ||
| **/fitness_estimation_mutscan_limma.tsv |
There was a problem hiding this comment.
hmm, tsv files usually are quite stable. any clue what is different on the different platforms here?
There was a problem hiding this comment.
@mashehu yes, this is weird... I'm also wondering. The edgeR and limma outputs contain heavily calculated stats (logFoldChange, PValue, etc.) with up to 14+ decimal places - maybe they're different because of differences in rounding?
There was a problem hiding this comment.
ah, that could be the case.
can you maybe then use https://github.com/lukfor/nft-csv to get at least a partial snapshot instead of ignoring them completely?
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).