Skip to content

Changes from PR review#366

Merged
jfy133 merged 2 commits intonf-core:devfrom
jfy133:dev
Mar 5, 2020
Merged

Changes from PR review#366
jfy133 merged 2 commits intonf-core:devfrom
jfy133:dev

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Mar 5, 2020

On the PR review for 2.1.0 release

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 merged commit ecdbdf9 into nf-core:dev Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants