Skip to content

Per sample genome sets#188

Merged
erikrikarddaniel merged 32 commits into
nf-core:devfrom
erikrikarddaniel:per-sample-genomes
Mar 20, 2026
Merged

Per sample genome sets#188
erikrikarddaniel merged 32 commits into
nf-core:devfrom
erikrikarddaniel:per-sample-genomes

Conversation

@erikrikarddaniel
Copy link
Copy Markdown
Member

@erikrikarddaniel erikrikarddaniel commented Mar 19, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/magmap branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This addresses issue #185 and adds the capacity to run mapping on sample-specific sets of genomes. The feature is only applied to remote genomes, not user-specified.

@github-actions
Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @erikrikarddaniel,

It looks like this pull-request is has been made against the erikrikarddaniel/nf-core-magmap master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the erikrikarddaniel/nf-core-magmap dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@erikrikarddaniel erikrikarddaniel changed the base branch from master to dev March 19, 2026 15:34
@erikrikarddaniel
Copy link
Copy Markdown
Member Author

@nf-core-bot fix linting

@erikrikarddaniel erikrikarddaniel marked this pull request as ready for review March 19, 2026 16:57
@erikrikarddaniel
Copy link
Copy Markdown
Member Author

@danilodileo : This is ready for review. One test fails, but it's because it failed to fetch the container.

Copy link
Copy Markdown
Collaborator

@danilodileo danilodileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!
I tried to re-run the test, let's see if it gets fixed

Copy link
Copy Markdown
Collaborator

@danilodileo danilodileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikrikarddaniel erikrikarddaniel merged commit 28e8354 into nf-core:dev Mar 20, 2026
36 of 38 checks passed
@danilodileo danilodileo mentioned this pull request Apr 3, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants