Merged
Conversation
chriswyatt1
reviewed
Mar 2, 2026
chriswyatt1
approved these changes
Mar 2, 2026
Contributor
chriswyatt1
left a comment
There was a problem hiding this comment.
Great, this all looks great to me.
Let's get this merged, if you have tested in your pipeline and it works as expected.
Contributor
|
Meant to add that the tests look good. They work as expected 👍 |
FernandoDuarteF
approved these changes
Mar 2, 2026
Contributor
FernandoDuarteF
left a comment
There was a problem hiding this comment.
The test works as expected, and I don't see any major issues.
Just added a few comments that you can probably disregard, so I'll just approve it.
correcting spaces Co-authored-by: Chris Wyatt <9978862+chriswyatt1@users.noreply.github.com>
keeping only histo and pdf in stub
Adding back files to stub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR is to create a new nf-core module for kmergenie.
PR checklist
Closes #10269
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda