Skip to content

topic migration bbmap pileup#10398

Merged
a-herzig merged 7 commits intonf-core:masterfrom
a-herzig:topic_bbmap_pileup
Mar 11, 2026
Merged

topic migration bbmap pileup#10398
a-herzig merged 7 commits intonf-core:masterfrom
a-herzig:topic_bbmap_pileup

Conversation

@a-herzig
Copy link
Contributor

PR checklist

Closes #10235

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mashehu
Copy link
Contributor

mashehu commented Mar 11, 2026

@nf-core-bot fix linting

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes

a-herzig and others added 2 commits March 11, 2026 13:49
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-herzig a-herzig added this pull request to the merge queue Mar 11, 2026
Merged via the queue into nf-core:master with commit f85761e Mar 11, 2026
48 checks passed
@a-herzig a-herzig deleted the topic_bbmap_pileup branch March 11, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topic channels: bbmap/pileup

4 participants