Skip to content

New macse refinealignment#10586

Merged
takiifujita-ui merged 41 commits intomasterfrom
new_macse_refinealignment
Mar 25, 2026
Merged

New macse refinealignment#10586
takiifujita-ui merged 41 commits intomasterfrom
new_macse_refinealignment

Conversation

@takiifujita-ui
Copy link
Contributor

We made new Macse module! Pls review it!

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also refer to the comments in #10590

@charles-plessy charles-plessy force-pushed the new_macse_refinealignment branch from a68ff47 to 758396d Compare March 13, 2026 08:53
@charles-plessy
Copy link
Contributor

Sorry, I hope I did not make a mess with my accidental force-push…

@takiifujita-ui
Copy link
Contributor Author

takiifujita-ui commented Mar 16, 2026

@jfy133
Good afternoon, It seems I finally finished working with this my first module. Is it possible to review this?

@takiifujita-ui
Copy link
Contributor Author

takiifujita-ui commented Mar 19, 2026

@camlloyd
Hello, thank you for your correction.
By the way, nf-test conda 8,9 are failed maybe due to conda environment. This nf-test failure is not inside our module, so can I pass through this error?

auto-merge was automatically disabled March 23, 2026 01:59

Pull request was closed

@takiifujita-ui
Copy link
Contributor Author

@jfy133
Thank you, I corrected, so would you mind if you can approve PR?

@takiifujita-ui takiifujita-ui added this pull request to the merge queue Mar 25, 2026
Merged via the queue into master with commit d5a80a3 Mar 25, 2026
22 checks passed
@takiifujita-ui takiifujita-ui deleted the new_macse_refinealignment branch March 25, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants