Skip to content

Bump bcftools version to 1.23.1#10993

Merged
georgiakes merged 9 commits intonf-core:masterfrom
georgiakes:master
Mar 24, 2026
Merged

Bump bcftools version to 1.23.1#10993
georgiakes merged 9 commits intonf-core:masterfrom
georgiakes:master

Conversation

@georgiakes
Copy link
Copy Markdown
Member

@georgiakes georgiakes commented Mar 20, 2026

Closes #9792

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@georgiakes georgiakes changed the title Bump bcftools version Bump bcftools version to 1.23.1 Mar 23, 2026
Copy link
Copy Markdown
Contributor

@DLBPointon DLBPointon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @georgiakes

Just a question on a couple of the snapshots having differing md5's. If this is expected then I'm happy to Approve.

Comment thread subworkflows/nf-core/bam_impute_stitch/tests/main.nf.test.snap
Comment thread subworkflows/nf-core/bam_impute_quilt/tests/main.nf.test.snap
Comment thread modules/nf-core/bcftools/roh/tests/main.nf.test.snap
Comment thread modules/nf-core/bcftools/mpileup/tests/main.nf.test.snap
Copy link
Copy Markdown
Contributor

@DLBPointon DLBPointon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgiakes georgiakes enabled auto-merge March 24, 2026 10:05
@georgiakes georgiakes disabled auto-merge March 24, 2026 10:24
@georgiakes georgiakes enabled auto-merge March 24, 2026 21:24
@georgiakes georgiakes added this pull request to the merge queue Mar 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@georgiakes georgiakes added this pull request to the merge queue Mar 24, 2026
Merged via the queue into nf-core:master with commit 4b21e2c Mar 24, 2026
138 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump BCFTOOLS version to 1.23

2 participants