Skip to content

update peddy container#11032

Merged
ramprasadn merged 5 commits intonf-core:masterfrom
ramprasadn:updatepeddycontainer
Mar 25, 2026
Merged

update peddy container#11032
ramprasadn merged 5 commits intonf-core:masterfrom
ramprasadn:updatepeddycontainer

Conversation

@ramprasadn
Copy link
Contributor

@ramprasadn ramprasadn commented Mar 24, 2026

PR checklist

Peddy image was built with a latest version of numpy, which didn't have some of the functions used by peddy. This PR addresses that by pinning numpy to an older version.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@ramprasadn
Copy link
Contributor Author

@nf-core-bot fix linting

@ramprasadn ramprasadn marked this pull request as ready for review March 24, 2026 11:16
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe why this change is needed in the PR description?

@ramprasadn ramprasadn added this pull request to the merge queue Mar 25, 2026
Merged via the queue into nf-core:master with commit 7773ae1 Mar 25, 2026
21 checks passed
@ramprasadn ramprasadn deleted the updatepeddycontainer branch March 25, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants