feat(simpleaf): bump to 0.25.0 with Seqera Wave container and topic-channel versions#11696
Conversation
…l versions - Bump simpleaf 0.19.5 -> 0.24.1 (Wave container community.wave.seqera.io/library/simpleaf:0.24.1--41e05fd46d838d92). - Align environment.yml pins with the container: alevin-fry 0.14.0, piscem 0.20.0, simpleaf 0.24.1. Removed salmon (no longer a simpleaf dependency in 0.24.x). - Migrate versions output from versions.yml emit to topic-channel emits per the new nf-core convention (matches t1k/build pattern). Each tool emits (process, tool, version) into the shared `versions` topic. - Update piscem index file assertions in tests: piscem 0.20 replaced .sshash/.json with .ssi/.ssi.mphf/_ver.json. Stub blocks updated to match. - Inline `ALEVIN_FRY_HOME=.` in the simpleaf eval expression because the eval runs in a separate shell context from the script block. - meta.yml regenerated by `nf-core modules lint --fix`, removed leftover versions.yml stanza. All nf-tests pass (5/5 simpleaf/index, 2/2 simpleaf/quant). nf-core modules lint shows 0 failures.
Note for reviewers: residual
|
simpleaf 0.25.0 (Wave: community.wave.seqera.io/library/simpleaf:0.25.0--b9f96d8b71a01864) bundles alevin-fry 0.15.0 with two upstream fixes that surfaced during the multiplex-quant work: - alevin-fry: per-record sample index now maps correctly to manifest ordinal in multi-barcode collation (fixes COMBINE-lab/simpleaf#195 — sample_name column omission and resulting polars i64 inference crash). - simpleaf: multiplex-quant auto-downloads chemistries.json on first use (fixes COMBINE-lab/simpleaf#196 — no more "Run `simpleaf chemistry refresh` first" error). Neither fix changes behavior for the index/quant code paths these modules exercise, but bumping keeps all simpleaf modules on a single, current container generation.
…hannel versions (nf-core#11696) * Update simpleaf to 0.24.1 with Seqera Wave container and topic-channel versions - Bump simpleaf 0.19.5 -> 0.24.1 (Wave container community.wave.seqera.io/library/simpleaf:0.24.1--41e05fd46d838d92). - Align environment.yml pins with the container: alevin-fry 0.14.0, piscem 0.20.0, simpleaf 0.24.1. Removed salmon (no longer a simpleaf dependency in 0.24.x). - Migrate versions output from versions.yml emit to topic-channel emits per the new nf-core convention (matches t1k/build pattern). Each tool emits (process, tool, version) into the shared `versions` topic. - Update piscem index file assertions in tests: piscem 0.20 replaced .sshash/.json with .ssi/.ssi.mphf/_ver.json. Stub blocks updated to match. - Inline `ALEVIN_FRY_HOME=.` in the simpleaf eval expression because the eval runs in a separate shell context from the script block. - meta.yml regenerated by `nf-core modules lint --fix`, removed leftover versions.yml stanza. All nf-tests pass (5/5 simpleaf/index, 2/2 simpleaf/quant). nf-core modules lint shows 0 failures. * Bump simpleaf to 0.25.0 in index + quant modules simpleaf 0.25.0 (Wave: community.wave.seqera.io/library/simpleaf:0.25.0--b9f96d8b71a01864) bundles alevin-fry 0.15.0 with two upstream fixes that surfaced during the multiplex-quant work: - alevin-fry: per-record sample index now maps correctly to manifest ordinal in multi-barcode collation (fixes COMBINE-lab/simpleaf#195 — sample_name column omission and resulting polars i64 inference crash). - simpleaf: multiplex-quant auto-downloads chemistries.json on first use (fixes COMBINE-lab/simpleaf#196 — no more "Run `simpleaf chemistry refresh` first" error). Neither fix changes behavior for the index/quant code paths these modules exercise, but bumping keeps all simpleaf modules on a single, current container generation.
Summary
versions.ymlfile to the new topic-channel convention (matchest1k/build).environment.ymlpins with what the container actually ships, including removing the no-longer-required salmon dependency.Container
community.wave.seqera.io/library/simpleaf:0.24.1--41e05fd46d838d92https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/83/83ab36a4aba7f26860f96dd73bb428a4a4eb05450c4cfc9488cf77adefad1adb/dataKey changes
Versions / dependencies
0.19.5→0.24.10.11.2→0.14.0(matches container)0.12.2→0.20.0(matches container)$(salmon --version)errored silently inside thecat <<-END_VERSIONSheredoc.Topic-channel versions
Both
main.nffiles now emit each tool's version as a separate topic-channel tuple instead of writingversions.yml:```groovy
tuple val("${task.process}"), val('alevin-fry'), eval("alevin-fry --version | sed 's/alevin-fry //'"), topic: versions, emit: versions_alevin_fry
tuple val("${task.process}"), val('piscem'), eval("piscem --version | sed 's/piscem //'"), topic: versions, emit: versions_piscem
tuple val("${task.process}"), val('simpleaf'), eval("ALEVIN_FRY_HOME=. simpleaf --version | sed 's/simpleaf //'"), topic: versions, emit: versions_simpleaf
```
The
ALEVIN_FRY_HOME=.prefix is needed because theeval()directive runs in a separate shell context from the script block where the env var is exported.Test updates
.sshash/.jsonfiles were replaced by.ssi/.ssi.mphf/_ver.json/.sigs.json/.tct/.tdct. Assertions inmain.nf.testand the corresponding stubtouchlines have been updated.snapshot(process.out.versions).match()tosnapshot(process.out.findAll { key, val -> key.startsWith(\"versions\") }).match()to capture the new per-tool topic emits.meta.ymlregenerated vianf-core modules lint --fix; obsoleteversions: - versions.ymlstanza removed by hand.Test plan
nf-test test modules/nf-core/simpleaf/index/tests/main.nf.test --profile docker— 5/5 PASSnf-test test modules/nf-core/simpleaf/quant/tests/main.nf.test --profile docker— 2/2 PASSnf-core modules lint simpleaf/index— 0 failuresnf-core modules lint simpleaf/quant— 0 failuresNote on residual lint warnings
A separate PR comment below explains the residual
main_nf_containerandcontainer_linkswarnings, which are upstream nf-core/tools quirks that surface on every Seqera Wave module (e.g.t1k/build,ngsbits/*) and are not actionable at the module level.