Skip to content

Use sanitized snapshots for gcta/makegrm tests#11765

Merged
SPPearce merged 1 commit into
nf-core:masterfrom
lyh970817:modules/gcta-makegrm-sanitize-snapshots
May 26, 2026
Merged

Use sanitized snapshots for gcta/makegrm tests#11765
SPPearce merged 1 commit into
nf-core:masterfrom
lyh970817:modules/gcta-makegrm-sanitize-snapshots

Conversation

@lyh970817
Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs?
  • If necessary, also make a PR on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core modules lint gcta/makegrm).
  • Ensure the test works with either Docker / Singularity. Conda CI tests can be quite slow; please only use them if you need them.

This updates the gcta/makegrm nf-test assertions to snapshot the sanitized full process.out object instead of manually snapshotting selected channels and versions. The updated snapshots now cover the complete emitted output contract for each successful test while preserving the targeted command-line checks.

Tested with:

  • nix-shell /home/andongni/Yandex.Disk/Projects/Research/nf-core/modules/shell.nix --run 'nf-test test modules/nf-core/gcta/makegrm/tests/main.nf.test --profile=docker --update-snapshot --verbose'
  • nix-shell /home/andongni/Yandex.Disk/Projects/Research/nf-core/modules/shell.nix --run 'nf-test test modules/nf-core/gcta/makegrm/tests/main.nf.test --profile=docker --verbose'

@SPPearce SPPearce added this pull request to the merge queue May 26, 2026
Merged via the queue into nf-core:master with commit 8d62f18 May 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants