Skip to content

biscuit/align nf-test and snapshot#4460

Merged
SPPearce merged 9 commits intomasterfrom
feat/biscuit-align-nf-test
May 22, 2024
Merged

biscuit/align nf-test and snapshot#4460
SPPearce merged 9 commits intomasterfrom
feat/biscuit-align-nf-test

Conversation

@sateeshperi
Copy link
Copy Markdown
Contributor

No description provided.

@sateeshperi sateeshperi requested a review from njspix as a code owner November 28, 2023 19:36
@sateeshperi sateeshperi requested review from a team and maxulysse and removed request for a team November 28, 2023 19:36
Copy link
Copy Markdown

@LeuThrAsp LeuThrAsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a stub test and swap to only testing for existence of the bam file?

Comment thread modules/nf-core/biscuit/align/tests/main.nf.test
@sateeshperi sateeshperi force-pushed the feat/biscuit-align-nf-test branch from d236ad6 to 134a858 Compare May 22, 2024 20:08
@SPPearce SPPearce enabled auto-merge May 22, 2024 20:20
@SPPearce SPPearce added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit f147c22 May 22, 2024
@SPPearce SPPearce deleted the feat/biscuit-align-nf-test branch May 22, 2024 20:30
tstoeriko pushed a commit to tstoeriko/nf-core-modules that referenced this pull request May 23, 2024
* biscuit/align nf-test and snapshot

* Update modules/nf-core/biscuit/align/tests/main.nf.test

* remove bam from snapshots

* remove bam,bai from snapshots

---------

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants