Skip to content

rename taxonomy files in kraken2/add module#5214

Merged
jfy133 merged 1 commit into
nf-core:masterfrom
alxndrdiaz:kraken2/add
Mar 19, 2024
Merged

rename taxonomy files in kraken2/add module#5214
jfy133 merged 1 commit into
nf-core:masterfrom
alxndrdiaz:kraken2/add

Conversation

@alxndrdiaz
Copy link
Copy Markdown
Member

@alxndrdiaz alxndrdiaz commented Mar 19, 2024

PR checklist

Closes #5213

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@alxndrdiaz alxndrdiaz requested review from a team, Aratz and jfy133 and removed request for a team March 19, 2024 02:27
This was referenced Mar 19, 2024
Closed
Merged
@jfy133 jfy133 added this pull request to the merge queue Mar 19, 2024
Merged via the queue into nf-core:master with commit dec4aaf Mar 19, 2024
jvfe added a commit to jvfe/modules that referenced this pull request Mar 19, 2024
@jvfe
Merge branch 'master' into fastx_collapser
f7e851f 
* master:
  Added module ALE (nf-core#5211)
  add cram support to bowtie2 (nf-core#5180)
  Add nf-test to minimap2 index (nf-core#5189)
  nf-test all wisecondorx modules (nf-core#5219)
  splitncigarreads added meta for references (nf-core#5224)
  More tests for FASTQ_FASTQC_UMITOOLS_FASTP (nf-core#5179)
  SNPEFF_SNPEFF with nf-test tests (nf-core#5204)
  del extra info from config, passed sing and docker tests (nf-core#5217)
  Added meta map to module and tests (nf-core#5191)
  Nftest htseq (nf-core#5220)
  remove pytest files for `bcftools sort` (nf-core#5218)
  Cellpose: updated to 3.0.1 (nf-core#5193)
  rename taxonomy files in kraken2/add module (nf-core#5214)
  add nf-test to bedtools/merge - nf-core#3936 (nf-core#5203)
@alxndrdiaz alxndrdiaz deleted the kraken2/add branch March 19, 2024 13:50
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@alxndrdiaz @tucano
rename taxonomy files in kraken2/add module (nf-core#5214)
ed495f4 
rename taxonomy files
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@alxndrdiaz @jennylsmith
rename taxonomy files in kraken2/add module (nf-core#5214)
38958f9 
rename taxonomy files
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@alxndrdiaz
rename taxonomy files in kraken2/add module (nf-core#5214)
da9b9a5 
rename taxonomy files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

@Aratz Aratz Awaiting requested review from Aratz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix taxonomy file names in kraken2/add module

2 participants

@alxndrdiaz @jfy133