Skip to content

Add snpeff#546

Merged
drpatelh merged 17 commits intonf-core:masterfrom
maxulysse:master_snpeff
Jul 6, 2021
Merged

Add snpeff#546
drpatelh merged 17 commits intonf-core:masterfrom
maxulysse:master_snpeff

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Jun 25, 2021

PR checklist

Closes #210

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

Copy link
Copy Markdown
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and all but what's the deal with all that Docker container and the build.sh file? 🤔
I mean it's on bioconda right?
I probably missed a slack discussion 😁

@grst
Copy link
Copy Markdown
Member

grst commented Jun 25, 2021

I missed that slack discussion, too! Would be great to document this somewhere in the module for future reference.

@KevinMenden
Copy link
Copy Markdown
Contributor

Linking the slack discussion:
https://nfcore.slack.com/archives/CJRH30T6V/p1624619248479500

@maxulysse maxulysse mentioned this pull request Jun 28, 2021
14 tasks
Comment thread software/snpeff/build.sh Outdated
@drpatelh drpatelh added the new module Adding a new module label Jul 5, 2021
Comment thread software/snpeff/environment.yml Outdated
Comment thread software/snpeff/environment.yml Outdated
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Comment thread software/snpeff/main.nf
Comment thread software/snpeff/main.nf Outdated
Comment thread software/snpeff/main.nf Outdated
Comment thread software/snpeff/main.nf Outdated
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@drpatelh
Copy link
Copy Markdown
Member

drpatelh commented Jul 6, 2021

Looks great @maxulysse ! Mainly some aesthetic changes for simplicity and to keep things in line with other nf-core/modules :)

Comment thread software/snpeff/meta.yml Outdated
Comment thread software/snpeff/meta.yml Outdated
Comment thread software/snpeff/meta.yml Outdated
maxulysse and others added 2 commits July 6, 2021 14:10
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@drpatelh
Copy link
Copy Markdown
Member

drpatelh commented Jul 6, 2021

Any idea why all of the tests are still failing?

@maxulysse
Copy link
Copy Markdown
Member Author

Any idea why all of the tests are still failing?

Checking that out now

Comment thread software/snpeff/main.nf Outdated
@maxulysse
Copy link
Copy Markdown
Member Author

Should be good now.
I removed the md5sum for the csv file as the file contain the date...

Copy link
Copy Markdown
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@drpatelh drpatelh merged commit e0d820f into nf-core:master Jul 6, 2021
@maxulysse maxulysse deleted the master_snpeff branch July 6, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: snpeff

4 participants