Add snpeff#546
Merged
drpatelh merged 17 commits intonf-core:masterfrom Jul 6, 2021
maxulysse:master_snpeff
Merged
Conversation
KevinMenden
reviewed
Jun 25, 2021
Contributor
KevinMenden
left a comment
There was a problem hiding this comment.
This looks good and all but what's the deal with all that Docker container and the build.sh file? 🤔
I mean it's on bioconda right?
I probably missed a slack discussion 😁
Member
|
I missed that slack discussion, too! Would be great to document this somewhere in the module for future reference. |
Contributor
|
Linking the slack discussion: |
drpatelh
reviewed
Jun 29, 2021
maxulysse
commented
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
drpatelh
reviewed
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Member
|
Looks great @maxulysse ! Mainly some aesthetic changes for simplicity and to keep things in line with other nf-core/modules :) |
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
drpatelh
reviewed
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
drpatelh
reviewed
Jul 6, 2021
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Member
|
Any idea why all of the tests are still failing? |
Member
Author
Checking that out now |
maxulysse
commented
Jul 6, 2021
Member
Author
|
Should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #210
<SOFTWARE>.version.txtfile.labelPROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wdPROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wdPROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd